address PR feedback

Signed-off-by: Roman Dmytrenko <[email protected]>
flipt-io · Dec 11, 2024 · 2a15c11 · 2a15c11
1 parent df7a7b8
commit 2a15c11
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/rpc/flipt/request.go b/rpc/flipt/request.go
@@ -49,17 +49,9 @@ type Request struct {
 	Status    Status   `json:"status"`
 }
 
-func WithNoNamespace() func(*Request) {
-	return func(r *Request) {
-		r.Namespace = ""
-	}
-}
-
 func WithNamespace(ns string) func(*Request) {
 	return func(r *Request) {
-		if ns != "" {
-			r.Namespace = ns
-		}
+		r.Namespace = ns
 	}
 }
 
@@ -104,7 +96,7 @@ func (req *GetNamespaceRequest) Request() []Request {
 }
 
 func (req *ListNamespaceRequest) Request() []Request {
-	return []Request{NewRequest(ResourceNamespace, ActionRead, WithNoNamespace())}
+	return []Request{NewRequest(ResourceNamespace, ActionRead, WithNamespace(""))}
 }
 
 func (req *CreateNamespaceRequest) Request() []Request {