[FL-3446] Feature check adjustment and nesting removal#2977
Merged
gornekich merged 11 commits intoflipperdevices:gornek/nfc_refactoringfrom Aug 11, 2023
Merged
Conversation
Added more logging
According to datasheet NTAG21x don't support this command, but some of them do. Only 02 flag works (3E02), so now tearing command checks if SingleCounter feature is supported by the card, then it can be treated as NTAGxx and only flag=2 can be read
This function checks whether current Ultralight instance supports feature, mentioned as a second paramete.
Conflicts: lib/nfc/protocols/mf_ultralight/mf_ultralight_listener.c lib/nfc/protocols/mf_ultralight/mf_ultralight_poller.c
RebornedBrain
requested review from
Astrrra,
DrZlo13,
gornekich,
hedger,
nminaylov and
skotopes
as code owners
gornekich
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)