Skip to content

UI: Clock on Desktop #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 10, 2023
Merged

UI: Clock on Desktop #2891

merged 15 commits into from
Aug 10, 2023

Conversation

xMasterX
Copy link
Contributor

@xMasterX xMasterX commented Jul 17, 2023 •
edited by skotopes
Loading

What's new

  • Added Option to enable clock on main screen

telegram-cloud-photo-size-2-5222478596562601826-x

Sorry wrong picture XDDD
Here is correct one:

Screenshot-20230718-010232

Feature Made by @gid9798 (and he asked me to make this PR)

Verification

  • Open Settings->Desktop and find new option called Show Clock
  • Enable new option and go back to main screen

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added UI Affects UI New Feature Contains an IMPLEMENTATION of a new feature labels Jul 20, 2023
@skotopes
Copy link
Contributor

@gid9798 @xMasterX I've made some changes, there is one more dangerous place left, but there is no proper solution available right now, so I'll merge it as is.

@skotopes skotopes merged commit f75fcd4 into flipperdevices:dev Aug 10, 2023
agarof pushed a commit to agarof/flipperzero-firmware that referenced this pull request Aug 30, 2023
@xMasterX @hedger
@skotopes @agarof
UI: Clock on Desktop (flipperdevices#2891)
01ac111 
* Clock on desktop
* Gui: gui_active_view_port_count
* Gui: move gui_active_view_port_count to private header, update docs
* Desktop: simplify desktop clock code
* Desktop: refactor clock
* Desktop: optimize clock code
* Desktop: 3rd cleanup round
* Desktop: 4th cleanup round, missing bits and pieces

Co-authored-by: hedger <[email protected]>
Co-authored-by: あく <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
New Feature Contains an IMPLEMENTATION of a new feature UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xMasterX @skotopes @hedger