Skip to content

NFC: Skip RATS if not needed#2694

Closed
AloneLiberty wants to merge 2 commits intoflipperdevices:devfrom
AloneLiberty:nfc-skip-rats
Closed

NFC: Skip RATS if not needed#2694
AloneLiberty wants to merge 2 commits intoflipperdevices:devfrom
AloneLiberty:nfc-skip-rats

Conversation

@AloneLiberty
Copy link
Copy Markdown
Contributor

Part of code taken (and improved) from pending PR #2688, but doesn't depend on it

What's new

  • Skip RATS: Mifare Classic (SmartMX Classic/Plus in SL1) can't be read after 14443-4 activation (RATS). This PR removes mandatory sending of RATS, therefore now you can read Mifare Classic via Read Specific Card Type -> Read Mifare Classic

Verification

All read should be done via Read Specific Card Type -> Read Mifare Classic, should read Mifare Classic

  • Read SmartMX with Classic emulation (SAK 20)
  • Read Mifare Plus in SL1 on EMV card (again SmartMX?)
  • If an EMV application is planned before the NFC refactor: check EMV reading

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Should allow reading SmartMX and Plus in SL1
@hedger hedger added the NFC NFC-related label May 26, 2023
@gornekich
Copy link
Copy Markdown
Member

Hello @AloneLiberty
The idea is good. The problem I can see is that we can't properly identify Mifare Classic type which is iso-14443-4a complient (like Mifare Classic Plus 2k / 4k). We planned to add support for these cards during NFC refactoring.

I convert this PR to draft for now.

@gornekich gornekich marked this pull request as draft May 26, 2023 11:32
@AloneLiberty
Copy link
Copy Markdown
Contributor Author

We planned to add support for these cards during NFC refactoring.

Main point of this PR is hot-patch this issue before NFC refactor, as it won't be issue after.

@gornekich
Copy link
Copy Markdown
Member

I got your point. But I am afraid that this would raise more questions. When I read Mifare Classic Plus 4k, it is identified and Mifare Classic 1k and not all sectors are read.

I prefer to add full support of these type of cards later, then partially read them and save as incorrect types now

@AloneLiberty AloneLiberty deleted the nfc-skip-rats branch May 26, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NFC NFC-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants