NFC: Skip RATS if not needed#2694
Closed
AloneLiberty wants to merge 2 commits intoflipperdevices:devfrom
Closed
Conversation
Should allow reading SmartMX and Plus in SL1
Member
|
Hello @AloneLiberty I convert this PR to draft for now. |
Contributor
Author
Main point of this PR is hot-patch this issue before NFC refactor, as it won't be issue after. |
Member
|
I got your point. But I am afraid that this would raise more questions. When I read Mifare Classic Plus 4k, it is identified and Mifare Classic 1k and not all sectors are read. I prefer to add full support of these type of cards later, then partially read them and save as incorrect types now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of code taken (and improved) from pending PR #2688, but doesn't depend on it
What's new
Verification
All read should be done via Read Specific Card Type -> Read Mifare Classic, should read Mifare Classic
Checklist (For Reviewer)