Skip to content

Desktop: Set external apps as favorites#1816

Merged
skotopes merged 11 commits intoflipperdevices:devfrom
djsime1:external-favorites
Oct 13, 2022
Merged

Desktop: Set external apps as favorites#1816
skotopes merged 11 commits intoflipperdevices:devfrom
djsime1:external-favorites

Conversation

@djsime1
Copy link
Contributor

@djsime1 djsime1 commented Oct 2, 2022

What's new

  • Revised favorite app struct from ID to location (internal/external) and name/file.
  • Selecting internal favorite app remains the same.
  • Selecting "Applications" opens file browser to select a .fap file.
  • Also fixes the issue of favorites changing if app ID changed.

Verification

  • Select "Applications" as a favorite app to verify you're prompted with the file browser.
  • Once a external application is selected, launch it from desktop with LEFT button.
  • If the application is removed, FAP loader shows that the file is missing.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@djsime1
Copy link
Contributor Author

djsime1 commented Oct 3, 2022

Tentative demo video:

1664732180_qFlipper.mp4

Won't be updating until #1795 and #1812 get merged.

@djsime1 djsime1 marked this pull request as ready for review October 7, 2022 16:35
@djsime1
Copy link
Contributor Author

djsime1 commented Oct 7, 2022

Original video is now outdated, file browser entries load app name and icon. The loading spinner is also displayed while the app is loading. Everything should be ready to go!

@skotopes skotopes self-assigned this Oct 7, 2022
@djsime1 djsime1 changed the title Set external apps as favorites Desktop: Set external apps as favorites Oct 8, 2022
@djsime1
Copy link
Contributor Author

djsime1 commented Oct 8, 2022

1665160995_qFlipper.mp4

@skotopes skotopes added New Feature Contains an IMPLEMENTATION of a new feature Core+Services HAL, furi & core system services labels Oct 8, 2022
@skotopes skotopes merged commit d5b2395 into flipperdevices:dev Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core+Services HAL, furi & core system services New Feature Contains an IMPLEMENTATION of a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants