Skip to content

Add ActiveRecord validations to mirror table NOT NULL constraint #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add ActiveRecord validations to mirror table NOT NULL constraint #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/flipper/adapters/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ class Feature < Model
].join

has_many :gates, foreign_key: "feature_key", primary_key: "key"

validates :key, presence: true
end

# Private: Do not use outside of this adapter.
Expand All @@ -30,6 +32,9 @@ class Gate < Model
"flipper_gates",
Model.table_name_suffix,
].join

validates :feature_key, presence: true
validates :key, presence: true
end

VALUE_TO_TEXT_WARNING = <<-EOS
Expand Down