Skip to content

Commit

Permalink
refactor: get the required variables with MethodCall
Browse files Browse the repository at this point in the history
  • Loading branch information
kyoto7250 committed May 25, 2022
1 parent e47c5b0 commit d0f93c1
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions clippy_lints/src/get_first.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,11 @@ declare_lint_pass!(GetFirst => [GET_FIRST]);
impl<'tcx> LateLintPass<'tcx> for GetFirst {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>) {
if_chain! {
if let hir::ExprKind::MethodCall(_, expr_args, _) = &expr.kind;
if let hir::ExprKind::MethodCall(_, [struct_calling_on, method_arg], _) = &expr.kind;
if let Some(expr_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
if match_def_path(cx, expr_def_id, &paths::SLICE_GET) && expr_args.len() == 2;
if match_def_path(cx, expr_def_id, &paths::SLICE_GET);

if let Some(struct_calling_on) = expr_args.get(0);
if let Some(_) = is_slice_of_primitives(cx, struct_calling_on);

if let Some(method_arg) = expr_args.get(1);
if let hir::ExprKind::Lit(Spanned { node: LitKind::Int(0, _), .. }) = method_arg.kind;

then {
Expand Down

0 comments on commit d0f93c1

Please sign in to comment.