fix: use long long on Windows #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
Author
|
I tried to add the 32 bit Linux build back to CI but it doesn't seem to have worked... |
Collaborator
Author
|
Okay the wheels are building in 32 bit linux and passing basic tests but it doesn't seem that there is a straight-forward way to run a CI job in a 32 bit OS to do a proper test. |
oscarbenjamin
force-pushed
the
pr_slong
branch
from
3be6151 to
dc6151f
Compare
Collaborator
Author
|
Okay, I'll merge this now so we can focus on making the Windows wheels work. |
This was referenced Dec 13, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
There might be more places that needs to be fixed to use
slongrather thanlongbut this is an intentionally minimal change that achieves the basic goal of getting python-flint to work on Windows. With this and #26 I was able to make a working Windows wheel that locally passed all tests.