Skip to content

Fix error messages from fmpq constructor #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix error messages from fmpq constructor #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/flint/types/fmpq.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,25 +84,25 @@ cdef class fmpq(flint_scalar):
p = fmpz(p)
q = fmpz(1)
else:
p = any_as_fmpq(p)
if p is NotImplemented:
p2 = any_as_fmpq(p)
if p2 is NotImplemented:
raise TypeError("cannot create fmpq from object of type %s" % type(p))
fmpq_set(self.val, (<fmpq>p).val)
fmpq_set(self.val, (<fmpq>p2).val)
return
else:
raise TypeError("fmpq() takes at most 2 arguments (%d given)" % len(args))

p = any_as_fmpz(p)
if p is NotImplemented:
p2 = any_as_fmpz(p)
if p2 is NotImplemented:
raise TypeError("cannot create fmpq from object of type %s" % type(p))
q = any_as_fmpz(q)
if q is NotImplemented:
q2 = any_as_fmpz(q)
if q2 is NotImplemented:
raise TypeError("cannot create fmpq from object of type %s" % type(q))
if fmpz_is_zero((<fmpz>q).val):
if fmpz_is_zero((<fmpz>q2).val):
raise ZeroDivisionError("cannot create rational number with zero denominator")

fmpz_set(fmpq_numref(self.val), (<fmpz>p).val)
fmpz_set(fmpq_denref(self.val), (<fmpz>q).val)
fmpz_set(fmpq_numref(self.val), (<fmpz>p2).val)
fmpz_set(fmpq_denref(self.val), (<fmpz>q2).val)
fmpq_canonicalise(self.val)

def __richcmp__(s, t, int op):
Expand Down