Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions and add automatic releases #149

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

oscarbenjamin
Copy link
Collaborator

Work in progress...

@edgarcosta
Copy link
Member

It also might be worth it to go all the way to 3.1.3-p1

@oscarbenjamin
Copy link
Collaborator Author

It also might be worth it to go all the way to 3.1.3-p1

Why is it called 3.1.3-p1?

@edgarcosta
Copy link
Member

edgarcosta commented Jul 1, 2024

I could have called it 3.1.4, and perhaps should have, but the only thing that changed from 3.1.3 was updating the VERSION before bootstrapping, to fix:
Homebrew/homebrew-core#166490 (comment)

@oscarbenjamin
Copy link
Collaborator Author

Ah, okay. The website doesn't have anything past 3.1.2:
https://flintlib.org/downloads.html

@edgarcosta
Copy link
Member

That is indeed true, and someone already created an issue: flintlib/flint#2022

Comment on lines +159 to +168
# Deploy wheels and sdist to PyPI

pypi_release:
name: Publish to PyPI
needs: [build_wheels, build_sdist]
# Run only when a tag is pushed to the flintlib/python-flint repo
if: "github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.owner == 'flintlib'"
environment:
name: pypi
url: https://pypi.org/p/sympy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged I will test pushing a tag to trigger release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might need a few attempts while fixing up the Actions workflow.

I guess it might work first time...

@oscarbenjamin oscarbenjamin merged commit d8c5c84 into flintlib:master Jul 1, 2024
30 checks passed
@oscarbenjamin oscarbenjamin deleted the pr_bump_versions branch July 1, 2024 20:22
@oscarbenjamin
Copy link
Collaborator Author

I've just pushed the tag and the workflow is running:
https://github.com/flintlib/python-flint/actions/runs/9750608228

@oscarbenjamin
Copy link
Collaborator Author

(It'll take about 30 minutes to reach the point where I can approve deployment.)

@oscarbenjamin
Copy link
Collaborator Author

@oscarbenjamin
Copy link
Collaborator Author

@oscarbenjamin
Copy link
Collaborator Author

Seems to be working so after gh-155 I think it will work:
https://github.com/flintlib/python-flint/actions/runs/9751640936

- [gh-144](https://github.com/flintlib/python-flint/pull/144)
Add `rel_one_ccuracy_bits` to `arb` and `acb`.
- [gh-142](https://github.com/flintlib/python-flint/pull/142)
Add `acb_theta` (only available for Flint >= 3.1).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about what acb_theta is but I get the impression that it warrants a more significant release note (that someone else would need to write).

@oscarbenjamin
Copy link
Collaborator Author

Okay here you go Edgar:
https://pypi.org/project/python-flint/0.7.0a2/#files

pip install --pre python-flint will give all the acb_theta you want!

if: "github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.owner == 'flintlib'"
environment:
name: pypi
url: https://pypi.org/p/sympy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks I forgot to change the URL when adapting this code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants