-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions and add automatic releases #149
Conversation
It also might be worth it to go all the way to 3.1.3-p1 |
Why is it called 3.1.3-p1? |
I could have called it 3.1.4, and perhaps should have, but the only thing that changed from 3.1.3 was updating the VERSION before bootstrapping, to fix: |
Ah, okay. The website doesn't have anything past 3.1.2: |
That is indeed true, and someone already created an issue: flintlib/flint#2022 |
# Deploy wheels and sdist to PyPI | ||
|
||
pypi_release: | ||
name: Publish to PyPI | ||
needs: [build_wheels, build_sdist] | ||
# Run only when a tag is pushed to the flintlib/python-flint repo | ||
if: "github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.owner == 'flintlib'" | ||
environment: | ||
name: pypi | ||
url: https://pypi.org/p/sympy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged I will test pushing a tag to trigger release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might need a few attempts while fixing up the Actions workflow.
I guess it might work first time...
I've just pushed the tag and the workflow is running: |
(It'll take about 30 minutes to reach the point where I can approve deployment.) |
Didn't work. Trying again after gh-153: |
Seems to be working so after gh-155 I think it will work: |
- [gh-144](https://github.com/flintlib/python-flint/pull/144) | ||
Add `rel_one_ccuracy_bits` to `arb` and `acb`. | ||
- [gh-142](https://github.com/flintlib/python-flint/pull/142) | ||
Add `acb_theta` (only available for Flint >= 3.1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about what acb_theta
is but I get the impression that it warrants a more significant release note (that someone else would need to write).
Okay here you go Edgar:
|
if: "github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.owner == 'flintlib'" | ||
environment: | ||
name: pypi | ||
url: https://pypi.org/p/sympy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks I forgot to change the URL when adapting this code...
Work in progress...