Add Basic CI Tests - #3
Merged
Merged
Conversation
This change introduces some basic PR-time CI tests. Specifically, this will run: * format check * `go vet` * `go test -race` * `go build`
asafbennatan
approved these changes
Oct 22, 2025
9 tasks
adalton
added a commit
that referenced
this pull request
Jul 8, 2026
…on data (#44) ## Summary - Fix feedback loop that caused 14 AI sessions ($34) on a single PR due to silent reply failures resetting the retry counter and stale `comment-responses.json` from prior sessions causing false success - Clean AI output files between feedback sessions to prevent stale data from being read as current - Reply functions now return posted count; critical paths (final-attempt, AI-responses) fail when zero replies land - `handleNoChanges` now handles final-attempt scenario with "unable to address" replies - Cost labels use round-based numbering with retries and outcome suffixes (e.g., "Feedback (2) retry 1 (no changes)") instead of sequential "Feedback #3", and parenthesized numbers to avoid GitHub autolinks ## Test plan - [x] `TestExecuteFeedback_StaleCommentResponsesCleaned` — stale file from prior session doesn't cause false success - [x] `TestExecuteFeedback_NoChanges_WithCommentResponses` — AI writing responses during session (not pre-written) works correctly - [x] `TestExecuteFeedback_CleanupPreservesSessionContext` — session-context.md survives cleanup - [x] `TestFeedbackCostLabel` — all four branches (no-changes, infrastructure error, final attempt, success) - [x] `TestCountFeedbackRounds` — error and retry entries excluded from round count - [x] `TestFeedbackLabel` — round-based labeling with retries and suffixes - [x] All 37 feedback tests pass with `-race` - [x] Full test suite passes - [x] Lint clean (no new issues) Assisted-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces some basic PR-time CI tests. Specifically, this will run:
go vetgo test -racego build