Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Fix image rendering #1855

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

daquinteroflex
Copy link
Collaborator

Fixes image rendering, building in process but opening before it finishes. Will update description.

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daquinteroflex so images need to be in Notes?

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Jul 25, 2024

Yep, sorry took a bit of time to build to test. It has to be under Notes so it renders properly in our docs template.

Screenshot from 2024-07-25 14-27-21

Will just get the tests to pass, then merge directly to latest to fix

@daquinteroflex daquinteroflex marked this pull request as ready for review July 25, 2024 13:31
@tylerflex
Copy link
Collaborator

@daquinteroflex should we merge this into develop?

@daquinteroflex daquinteroflex changed the base branch from latest to develop August 2, 2024 17:31
@tylerflex tylerflex added 2.7 will go into version 2.7.* .2 labels Aug 2, 2024
@daquinteroflex daquinteroflex merged commit f1c45d5 into develop Aug 5, 2024
16 checks passed
@daquinteroflex daquinteroflex deleted the dario/filter/fix_image_render branch August 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.* .2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants