Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1778 #1779

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix for #1778 #1779

merged 3 commits into from
Jun 20, 2024

Conversation

lucas-flexcompute
Copy link
Collaborator

No description provided.

dmarek-flex
dmarek-flex approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@dmarek-flex dmarek-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lucas-flexcompute
Copy link
Collaborator Author

No problem. I just didn't know if this should go into develop or cherry-picked for the next 2.7.x release. Maybe @momchil-flex can direct us here?

@momchil-flex
Copy link
Collaborator

develop makes sense thanks! Usually after an official release various small bugfixes accumulate for a patch not too long after.

@lucas-flexcompute lucas-flexcompute changed the base branch from pre/2.8 to develop June 20, 2024 14:24
alec-flexcompute
alec-flexcompute approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@alec-flexcompute alec-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Although looks like a test isn't passing.

tylerflex and others added 2 commits June 20, 2024 13:19
@tylerflex @lucas-flexcompute
pre 2.8
0790c15
@lucas-flexcompute
Fix for #1778
0f4c07a 
Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
@lucas-flexcompute lucas-flexcompute force-pushed the lucas/transformed_intersection_fix branch from e5b67c5 to 0f4c07a Compare June 20, 2024 16:19
@lucas-flexcompute
Update notebooks submodule
cc1c209 
Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
@lucas-flexcompute lucas-flexcompute merged commit b860a4f into develop Jun 20, 2024
16 checks passed
@lucas-flexcompute lucas-flexcompute deleted the lucas/transformed_intersection_fix branch June 20, 2024 18:43
QimingFlex pushed a commit that referenced this pull request Jun 25, 2024
@lucas-flexcompute @tylerflex @QimingFlex
Fix for #1778 (#1779)
4b03b6e 
* Fix for #1778
* Update notebooks submodule

Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
Co-authored-by: Tyler Hughes <[email protected]>
m-bone pushed a commit that referenced this pull request Jul 1, 2024
@lucas-flexcompute @tylerflex @m-bone
Fix for #1778 (#1779)
2e83ed2 
* Fix for #1778
* Update notebooks submodule

Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
Co-authored-by: Tyler Hughes <[email protected]>
m-bone pushed a commit that referenced this pull request Jul 2, 2024
@lucas-flexcompute @tylerflex @m-bone
Fix for #1778 (#1779)
088db69 
* Fix for #1778
* Update notebooks submodule

Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
Co-authored-by: Tyler Hughes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarek-flex dmarek-flex dmarek-flex approved these changes

@alec-flexcompute alec-flexcompute alec-flexcompute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucas-flexcompute @momchil-flex @alec-flexcompute @dmarek-flex @tylerflex