-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show cost for EME, HEAT, and MODE. Remove URL from EME webapi. #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've merged your webapi PR and redeployed the service - give it a try now!
However, what exactly was happening before? In principle if the webapi errors, a metadata pipeline is meant to be kicked off such that the estimate should always eventually appear. Was that not what you were seeing?
My other comments are a bit nit-picky, but it would be great to avoid some code duplication.
How about we define a SOLVER_NAME
dict that links task_type
to the name we want printed in log messages. Then we can have a single message here and also replace this with just solver_name = SOLVER_NAME[task_type]
?
I see. When I called I see that now when I call I converted this to a draft, I need to test a bit more. |
@momchil-flex |
Looks good, played around a bit and it worked well. Hopefully no major issues will come up. :) |
Tested for HEAT and EME.