Fix: port computations for coarse grids #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added grid size check to TerminalComponentModeler and improved test coverage of smatrix plugin
dmarek-flex
force-pushed
the
dmarek/fix_port_computations
branch
from
425ddf1
to
bdb9420
Compare
tylerflex
approved these changes
Mar 18, 2024
|
BTW, keep in mind that the current and voltage computations are about to be changed in #1542, so they will be much simpler. |
weiliangjin2021
approved these changes
Mar 19, 2024
| @@ -263,13 +276,21 @@ def port_current(port: LumpedPort, sim_data: SimulationData) -> xr.DataArray: | |||
| h1_field = h_field.isel({orth_component: orth_index - 1}) | |||
| h2_field = h_field.isel({orth_component: orth_index}) | |||
| h_field = h1_field - h2_field | |||
|
|
|||
| # Find exact bounds of port taking into consideration the Yee grid | |||
There was a problem hiding this comment.
a bit more explanation?
There was a problem hiding this comment.
I need to modify this computation anyways in #1542, and it should be much simpler.
There was a problem hiding this comment.
Is this PR closed in favor of #1542. It seems the same change happening there already?
There was a problem hiding this comment.
There was a problem hiding this comment.
sounds good. feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing a new example I found some issues with the way LumpedPorts are handled.
I did not modify the changelog, since these are all changes that could be considered within the original LumpedPorts PR.