-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump trimesh version to >=4,<4.2 #1557
Conversation
Hi Casey, no worries, that looks about right! The pre v3 trimesh |
Nice, thanks for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @caseyflex !
Hey @caseyflex could you update the submodule commit. for
|
d577f8f
to
df2ade8
Compare
done! |
To restore compatibility with gdsfactory. Ran tests with
trimesh=4.0.0
andtrimesh=4.1.8
.@daquinteroflex can you take a look at
poetry.lock
? Something isn't right, I ranpoetry update trimesh
but it also changedpython-versions
and[package.extras]
.@lucas-flexcompute can you take a look at the gds-related files to see if I missed anything?