Fix last_enrolled_at for macOS devices when re-enrolling to MDM
#20173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roperzh
previously approved these changes
Jul 3, 2024
gillespi314
previously approved these changes
Jul 3, 2024
| @@ -770,30 +770,37 @@ func updateMDMAppleHostDB( | |||
| ) error { | |||
| refetchRequested, lastEnrolledAt := mdmHostEnrollFields(mdmHost) | |||
There was a problem hiding this comment.
I wonder if it would make things easier to maintain to split up this abstraction and calculate these two values separately when needed?
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added changes file
changes/20059-fix-last_enrolled_atdocumenting the fix - Fixed
last_enrolled_atfield update for macOS hosts re-enrolling via MDM - Updated tests to cover the new functionality
- Conducted manual QA for the changes
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -0,0 +1 @@ | |||
| * Fixed bug that set `Added to Fleet` to `Never` after macOS hosts re-enrolled to Fleet via MDM. | |||
There was a problem hiding this comment.
ℹ️ info: Documented the fix for the last_enrolled_at field issue for macOS re-enrollment.
|
I'm assuming I was requested by mistake? |
Maybe because of the change to |
lucasmrod
added a commit
that referenced
this pull request
Jul 11, 2024
…0173) - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [X] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [X] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [X] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [X] Added/updated tests - [X] Manual QA for all new/changed functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20059
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci).