Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

chore: manually provide ip addresses to index provider #382

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

b0xtch
Copy link
Contributor

@b0xtch b0xtch commented Feb 10, 2023

Why

Autonat does not deterministically get the IP address of the node.

What

  • Change domain to use public IP address

Checklist

  • I have made corresponding changes to the tests
  • I have made corresponding changes to the documentation
  • I have run the app using my feature and ensured that no functionality is broken

@ozwaldorf
Copy link
Member

ozwaldorf commented Feb 10, 2023

we should migrate old configs to new, since domain is just a multiaddr, we can easily move it to address as a single entry vec. Also note that domain was migrated out of provider config and into server config

@b0xtch
Copy link
Contributor Author

b0xtch commented Feb 10, 2023

we should migrate old configs to new, since domain is just a multiaddr, we can easily move it to address as a single entry vec. Also note that domain was migrated out of provider config and into server config

can you elaborate, what old vs new?

@ozwaldorf
Copy link
Member

ozwaldorf commented Feb 10, 2023

can you elaborate, what old vs new?

For nodes properly setup with a domain, they'd already have something configured like

[server_config]
domain = "/dns/foo.bar/" # recently migrated out of provider_config since its specific to the entire node
port = 4069
addr = "0.0.0.0"
...

Since the new provider_config.addresses is just a vector of addresses to use for the announcement, we could reuse the domain value configured already right?

@b0xtch
Copy link
Contributor Author

b0xtch commented Feb 10, 2023

can you elaborate, what old vs new?

For nodes properly setup with a domain, they'd already have something configured like

[server_config]
domain = "/dns/foo.bar/" # recently migrated out of provider_config since its specific to the entire node
...

Since the new provider_config.addresses is just a vector of addresses to use for the announcement, we could reuse the domain value configured already right?

they would need to move to using IP addresses

crates/ursa/src/main.rs Outdated Show resolved Hide resolved
@kckeiks
Copy link
Collaborator

kckeiks commented Feb 10, 2023

Looks good. I was talking with @theBeardA about which port number the gateway should use. If we plan to always encrypt the connection between gateway and node (I think, correct me if im wrong please) using HTTPS, 443 is a good default. If the port will not be advertised anymore, we should update the gateway here https://github.com/fleek-network/ursa/blob/main/crates/ursa-gateway/src/resolver/mod.rs#L124.

@b0xtch b0xtch merged commit e20ab1f into main Feb 13, 2023
@b0xtch b0xtch deleted the chore/manual-ip-for-indexer branch February 13, 2023 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants