feat: reusable ip-based firewall/rate limiting, hmac on admin rpc #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kckeiks
reviewed
Jun 11, 2024
|
|
||
| match self { | ||
| ConnectionPolicy::Blacklist(blacklist) => { | ||
| if blacklist.contains(&ip) { |
There was a problem hiding this comment.
nit: a small optimization would be to call remove directly.
| pub hmac_secret: Option<PathBuf>, | ||
| } | ||
|
|
||
| impl From<Config> for FirewallConfig { |
There was a problem hiding this comment.
Is this needed considering firewall is a public field?
| pub rate_limiting: RateLimitingConfig, | ||
| } | ||
|
|
||
| // todo stricter defaults? |
There was a problem hiding this comment.
When in doubt, I tend to avoid the default and let the users decide so that there are no suprises. Makes debugging easier imo.
nhtyy
force-pushed
the
n/rpc
branch
4 times, most recently
from
969a4ae to
9ad72ad
Compare
snormore
reviewed
Jun 17, 2024
snormore
reviewed
Jun 17, 2024
snormore
reviewed
Jun 17, 2024
nhtyy
force-pushed
the
n/rpc
branch
2 times, most recently
from
9e38e0c to
eaa0826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also: