Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose map bounds #99

Merged
merged 5 commits into from
Sep 14, 2018
Merged

Expose map bounds #99

merged 5 commits into from
Sep 14, 2018

Conversation

xqwzts
Copy link
Contributor

@xqwzts xqwzts commented Sep 11, 2018

Provides a way for clients to get the current map bounds.

Fixes #87

  • Calculates the map bounds on move.
  • Caches the value in MapState and exposes a bounds getter.
  • Adds bounds property to MapPosition, and provides it upon triggering the onPositionChanged callback.
  • Adds bounds getter to MapController/MapControllerImpl.
  • Updates the MapController example with a button that shows the current bounds in a SnackBar.

@xqwzts xqwzts mentioned this pull request Sep 11, 2018
@johnpryan
Copy link
Collaborator

Thanks for the PR - I'll take a look as soon as I can

@johnpryan johnpryan self-assigned this Sep 12, 2018
@johnpryan johnpryan self-requested a review September 12, 2018 23:27
@johnpryan johnpryan removed their assignment Sep 12, 2018
@johnpryan johnpryan merged commit 2c38f3b into fleaflet:master Sep 14, 2018
@johnpryan
Copy link
Collaborator

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants