fixed exception during initialization #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpryan
requested changes
Jul 30, 2019
lib/src/map/map.dart
Outdated
| @@ -115,7 +115,7 @@ class MapState { | |||
| zoom = _fitZoomToBounds(zoom); | |||
| final mapMoved = center != _lastCenter || zoom != _zoom; | |||
|
|
|||
| if (!mapMoved || options.isOutOfBounds(center) || !bounds.isValid) { | |||
| if (_lastCenter != null && (!mapMoved || options.isOutOfBounds(center) || !bounds.isValid)) { | |||
There was a problem hiding this comment.
I think this file needs to be formatted - can you run dartfmt?
|
Done |
johnpryan
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I observed that when you have enabled 'break on all exceptions' that flutter_map threw an exception while initializing due to that
_lastCenterwas not initialized. I changed a little bit the sequence and made sure that in this casemoveis executed which initializes_lastCentercorrectly.IMHO it would be worth to have a closer look over the whole initialization process sometimes.