Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polygon hit detection when map is rotated #1942

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

monsieurtanuki
Copy link
Contributor

@monsieurtanuki monsieurtanuki commented Aug 5, 2024

Fixes #1934.

Removed an optimization that prevented the hit test to work for polygons on rotated maps.

@JaffaKetchup JaffaKetchup changed the title fix: 1934 - polygon hit even with rotated maps fix: polygon hit detection when map is rotated Aug 6, 2024
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this :)

(Just had to fix some lint issues, one unrelated but preventing merge.)

@JaffaKetchup JaffaKetchup merged commit a2aada4 into fleaflet:master Aug 6, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @JaffaKetchup for your review!

One optimization path would be to keep the code I've just removed only for map rotation == 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Polygon hitbox does not take into account map rotation
2 participants