perf: expose isPointInPolygon and make 40% faster (at least in JIT mode)
#1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I mostly looked at the function because I wanted to use it myself but it was private. So I thought, if I expose it then I could at least put a ribbon on it by adding a benchmark. Before: (duration: 0:00:05.998949, name: In circle) (duration: 0:00:06.866919, name: Not in circle) After: (duration: 0:00:03.649496, name: In circle) (duration: 0:00:04.611599, name: Not in circle) Note, I opportunistically touched crs to remove the dart:ui dependency. This way it can be compiled with dart (w/o flutter) rendering the instructions in the benchmark correct again. Unfortunately, pointInPolygon is not so fortunate and needs flutter due to the dependency on ui.Offset. That's why I could only run it with "flutter test" in JIT mode.
JaffaKetchup
changed the title
isPointInPolygon 40% faster (at least in JIT mode)
JaffaKetchup
changed the title
isPointInPolygon 40% faster (at least in JIT mode)isPointInPolygon and make 40% faster (at least in JIT mode)
JaffaKetchup
reviewed
Jun 6, 2024
…point in hole" computation.
ignatz
commented
Jun 6, 2024
|
Sorry, I tagged on a bunch of other changes after looking a bit more at the implementation. Added a few comments. Hope it makes sense. |
ignatz
commented
Jun 6, 2024
…Polygon inputs. Would have caught previous misuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly looked at the function because I wanted to use it myself but it was private. So I thought, if I expose it then I could at least put a ribbon on it by adding a benchmark and make it go wroom.
Before:
(duration: 0:00:05.998949, name: In circle)
(duration: 0:00:06.866919, name: Not in circle)
After:
(duration: 0:00:03.649496, name: In circle)
(duration: 0:00:04.611599, name: Not in circle)
Note, I opportunistically touched crs to remove the dart:ui dependency. This way it can be compiled with dart (w/o flutter) rendering the instructions in the benchmark correct again. Unfortunately, pointInPolygon is not so fortunate and needs flutter due to the dependency on ui.Offset. That's why I could only run it with "flutter test" in JIT mode.