Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgraded some dependencies to re-introduce compatbility with Flutter 3.19 #1897

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

monsieurtanuki
Copy link
Contributor

Slightly downgraded package dependencies so that it works in flutter 3.19.

@JaffaKetchup
Copy link
Member

Thanks again :) However, I'm just wondering whether we should bump the minimum SDK version to 3.19, or further downgrade the depedency constraints, because I guess this could still cause issues for those on a version prior to 3.19.

@JaffaKetchup JaffaKetchup linked an issue May 30, 2024 that may be closed by this pull request
@monsieurtanuki
Copy link
Contributor Author

Thanks again :) However, I'm just wondering whether we should bump the minimum SDK version to 3.19, or further downgrade the depedency constraints, because I guess this could still cause issues for those on a version prior to 3.19.

@JaffaKetchup The idea for a public package like flutter_map would be to let the user configurations decide what is best by using low version numbers and the ^ syntax, except for versions that are really needed (e.g. bug fixes) or versions that are highly recommended (e.g. latlong2: ^0.9.1)
That would mean sort of rollbacking your previous pubspec.yaml, right?

Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, we can downgrade all the dependencies to their latest major version (or later if we need functionality in a minor/patch) later. Thanks 👍

@JaffaKetchup JaffaKetchup changed the title fix: 1896 - fine tuned pubspec dependencies fix: downgraded some dependencies to re-introduce compatbility with Flutter 3.19 Jun 1, 2024
@JaffaKetchup JaffaKetchup merged commit b69a0d7 into fleaflet:master Jun 1, 2024
7 checks passed
@JaffaKetchup JaffaKetchup linked an issue Jun 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] FlutterFlow dependencies issue on meta 1.12.0 [BUG] Too high package:meta dependency constraint
2 participants