-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PolylineLayer
throws exception: "The west longitude can't be smaller than the east longitude"
#1879
fix: PolylineLayer
throws exception: "The west longitude can't be smaller than the east longitude"
#1879
Conversation
PolylineLayer
throws exception for some Polylines
PolylineLayer
throws exception for some PolylinesPolylineLayer
throws exception: "The west longitude can't be smaller than the east longitude"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
My 2 cents: in double minX = 180;
double maxX = -180;
double minY = 90;
double maxY = -90; As a refactoring, we may be better off making those values |
thanks for the quick fix :) |
@mootw thanks for the review and @monsieurtanuki thanks for the comment. I added the requested refactoring. Does anyone want to take another look before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should also make it easier for external uses (for example where a Polygon
is painted over the entire world, and a hole created at the desired location).
Some linestrings caused the PolylineLayer to throw an assertion exception.
This bug was reported by borg_1of3 on discord: https://discord.com/channels/951867686378409984/1235305884620689558/1235305884620689558
The bug sneaked into the code base in #1834.