-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dottedSpacingFactor
to customize dotted polyline spacing
#1845
Conversation
dottedSpacingFactor
to customize dotted polyline spacing
Thanks for the pull request @gnassro! There are some small things I would prefer to have changed:
Then there are some general things I discovered while testing that you don't need to care about but are worth writing down:
|
@josxha the only thing that I didn't understand is, what do you mean by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks :). Will wait for a second review before merging.
Sorry for the delay, changes looking good. Thanks for updating the example app too.
This is a bug that is not related to this pull request. If you
Then the polyline doesn't change it's appearance from a dotted to a normal line. A quick guess is because the polyline hashCode gets cached it doesn't regocnizes the change - but anyways as said it's not related to this pr. Thanks a lot for the contribution! |
Now we can customize the space between dots if
isDotted=true