Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use radians2Degrees const from vector_math #1763

Merged
merged 1 commit into from
Dec 7, 2023
Merged

perf: use radians2Degrees const from vector_math #1763

merged 1 commit into from
Dec 7, 2023

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Dec 7, 2023

This PR is a follow up to #1743.
It makes use of the radians2Degrees from the vector_math package.

@josxha josxha added this to the v7.0 milestone Dec 7, 2023
@josxha josxha self-assigned this Dec 7, 2023
@josxha josxha mentioned this pull request Dec 7, 2023
Merged
@JaffaKetchup
Copy link
Member

Are there any other conversions that can be replaced? Let's just replace all of them now, and remove the leftover old functions.

@josxha
Copy link
Contributor Author

josxha commented Dec 7, 2023

These were the leftover usages of these functions from latlong2:

I currently know very little about the vector_math package but we can keep this PR open and turn it into an general "make better use of vector_math" PR.

JaffaKetchup
JaffaKetchup approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge this now, we can integrate more vector_math later.

mootw
mootw reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@mootw mootw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as we also remove the function definition of radianToDeg

@JaffaKetchup
Copy link
Member

(that concerned me as well, so I checked. it's from latlong2.)

@josxha josxha merged commit 135180b into fleaflet:master Dec 7, 2023
6 checks passed
@josxha josxha deleted the use-vector_math branch December 7, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mootw mootw mootw left review comments

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

@ibrierley ibrierley Awaiting requested review from ibrierley

@TesteurManiak TesteurManiak Awaiting requested review from TesteurManiak

Assignees

@josxha josxha

Labels
None yet
Projects
Development
Archived in project
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@josxha @JaffaKetchup @mootw