-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add animations to the controller #1757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
force-pushed
the
animation-in-controller
branch
2 times, most recently
from
December 3, 2023 22:34
e5ac81f
to
4f67f0d
Compare
josxha
force-pushed
the
animation-in-controller
branch
from
December 7, 2023 23:47
4f67f0d
to
ec81782
Compare
josxha
requested review from
TesteurManiak,
JaffaKetchup,
ibrierley and
mootw
December 12, 2023 00:51
JaffaKetchup
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested as this will be part of a much larger overhaul, but code seems to make sense. Feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds animations to the map controller for internal usage.
This pull request is a requirement for:
Progress:
In addition this pull request makes changes codecov to always succeed its CI workflows. (yes, finally!) I can create a separate PR for this if wanted.