Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add animations to the controller #1757

Merged
merged 21 commits into from
Dec 12, 2023

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Dec 3, 2023

This pull request adds animations to the map controller for internal usage.

This pull request is a requirement for:

Progress:

  • central AnimationController
  • moveAnimatedRaw()
  • moveAndRotateAnimatedRaw()
  • rotateAnimatedRaw()
  • stopAnimationRaw()
  • flingAnimatedRaw()

In addition this pull request makes changes codecov to always succeed its CI workflows. (yes, finally!) I can create a separate PR for this if wanted.

@josxha josxha added this to the v7.0 milestone Dec 3, 2023
@josxha josxha added the blocked This issue's resolution can't be worked on right now label Dec 3, 2023
@josxha josxha self-assigned this Dec 3, 2023
@josxha josxha force-pushed the animation-in-controller branch 2 times, most recently from e5ac81f to 4f67f0d Compare December 3, 2023 22:34
@josxha josxha removed the blocked This issue's resolution can't be worked on right now label Dec 7, 2023
@josxha josxha closed this Dec 7, 2023
@josxha josxha reopened this Dec 7, 2023
@fleaflet fleaflet deleted a comment from codecov bot Dec 10, 2023
@fleaflet fleaflet deleted a comment from codecov bot Dec 10, 2023
@josxha josxha marked this pull request as ready for review December 12, 2023 00:50
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested as this will be part of a much larger overhaul, but code seems to make sense. Feel free to merge.

@josxha josxha merged commit e7170da into fleaflet:master Dec 12, 2023
6 checks passed
@josxha josxha deleted the animation-in-controller branch December 12, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants