Fixed bugs and added tests for FlutterMapNetworkImageProvider
#1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it fails and fallback appropriately under different http responses.
|
Thanks for this, I'll see what I can do to fix the issue you mentioned in your description. Is it safe for me to work directly in this PR? |
|
Feel free to do as you need. |
This comment was marked as resolved.
This comment was marked as resolved.
…ider` failed to decode a non-image Fixed linting issues
JaffaKetchup
changed the title
FlutterMapNetworkImageProvider
JaffaKetchup
requested review from
ibrierley,
mootw,
TesteurManiak and
JaffaKetchup
JaffaKetchup
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing it fails and fallback appropriately under different http responses.
Currently the last test, "test load with invalid response (with successful fallback)" fails. The primary URL returns 200 OK but HTML not a image. The fallback URL is never attempted. Per the discussion on discord this may be a bug, however, it looks to fix this you need to go higher up the stack (I suspect TileImage) because the image isn't actually processed until then.