Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect Marker anchoring when counter-rotating #1623

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Fixed incorrect Marker anchoring when counter-rotating #1623

merged 3 commits into from
Sep 8, 2023

Conversation

JaffaKetchup
Copy link
Member

Fixes #1500. Marker.rotateAlignment is now automatically adjusted, where possible, to fix incorrect anchoring when rotate is true.

Also:

  • Removed AnchorAlign (without deprecation), preferring Alignment
  • Added new documentation

@JaffaKetchup
Fixed #1500
2820a74 
Removed `AnchorAlign` (without deprecation), preferring `Alignment`
Added new documentation
TesteurManiak
TesteurManiak approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaffaKetchup JaffaKetchup merged commit e6e5e50 into master Sep 8, 2023
7 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-1500 branch September 8, 2023 13:45
@JaffaKetchup JaffaKetchup mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TesteurManiak TesteurManiak TesteurManiak approved these changes

@ibrierley ibrierley Awaiting requested review from ibrierley

@mootw mootw Awaiting requested review from mootw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Markers with rotate: true do not adjust their anchor
2 participants
@JaffaKetchup @TesteurManiak