Implement MapCamera equality & hashCode
#1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Hi @jjoelson,
Thanks for resolving this yourself so quickly! I'll give it a test tomorrow based on your issue.
If you could just update your equality method to check for identity, as is good practise, that would be great :) I can do it if you don't have time.
JaffaKetchup
changed the title
== and hashCode in MapCameraMapCamera equality & hashCode
This will ensure assertions like the one described in [this issue](fleaflet#1613) work as intended.
jjoelson
force-pushed
the
1613-map-camera-assertion-fix
branch
from
0ee39be
to
12c71d6
Compare
|
Nice one @jjoelson! This would definitely be worth adding a test for. |
JaffaKetchup
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure assertions like the one described in this issue work as intended.