Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize num type #1482

Merged
merged 6 commits into from
May 5, 2023
Merged

Normalize num type #1482

merged 6 commits into from
May 5, 2023

Conversation

tlserver
Copy link
Contributor

@tlserver tlserver commented Apr 7, 2023

  1. CustomPoint<int> is not used in this plugin explicitly: change CustomPoint to always double to avoid potential error.
  2. Some property are num and some are double, but seem having no good reason: change to double for consistency.
  3. mapState.nonrotatedSize and mapState.size is always available after widget initlized: change its getter to non-nullable.
  4. CustomPoint.multiplyBy() have same functionality as operator *: make as deprecated.

TesteurManiak
TesteurManiak previously approved these changes Apr 7, 2023
Copy link
Collaborator

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaffaKetchup
Copy link
Member

Thanks @TesteurManiak. Will merge after #1475.

@JaffaKetchup
Copy link
Member

Hey @tlserver,
Unfortunately, #1475 has wreaked havoc on this PR. It appears as though many of the changes you made may have been fixed?
If you're still up to it, can you resolve the conflicts?
Apologies for the changes.

@tlserver
Copy link
Contributor Author

tlserver commented May 3, 2023

Ok, but I am traveling right now. I will go back tomorrow.

@tlserver
Copy link
Contributor Author

tlserver commented May 4, 2023

I try to resolve the conflicts.
1. CustomPoint<int> is not used in this plugin explicitly: change CustomPoint to always double to avoid potential error.

  1. TileCoordinates extend CustomPoint<int> now, so remade CustomPoint. Now explicitly declare the return type in double, int or T.
  2. Some property are num and some are double, but seem having no good reason: change to double for consistency.
  3. mapState.nonrotatedSize and mapState.size is always available after widget initlized: change its getter to non-nullable.
  4. CustomPoint.multiplyBy() have same functionality as operator *: make as deprecated. now removed for this PR is consider to be use for V4.

@TesteurManiak TesteurManiak self-requested a review May 4, 2023 09:32
@JaffaKetchup JaffaKetchup self-requested a review May 4, 2023 16:30
@JaffaKetchup JaffaKetchup dismissed TesteurManiak’s stale review May 4, 2023 16:30

Significant changes since review

@JaffaKetchup
Copy link
Member

Thanks @tlserver, we'll try to review this quickly.

@JaffaKetchup JaffaKetchup merged commit daa0c83 into fleaflet:master May 5, 2023
@tlserver tlserver deleted the normalize_num_type branch July 17, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants