Reduce unnecessary casts, use convert when unsafe #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TesteurManiak
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Looks good to me, @JaffaKetchup do you want to double check?
|
I'll take your word for it, I'll merge when I get a minute. |
JaffaKetchup
approved these changes
Sep 17, 2022
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LatLngBounds.fromPointsconverted degrees to radians, then radians back to degrees... Also used num and nullables although we were only dealing with doubles.Not sure if we can guarantee that all
CustomPoint<num>are in fact doubles, but left them for now since it would be a bigger change.