Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the zoom speed using the mouse wheel can be adjusted #1289

Merged
merged 2 commits into from
Jun 28, 2022
Merged

the zoom speed using the mouse wheel can be adjusted #1289

merged 2 commits into from
Jun 28, 2022

Conversation

mboe
Copy link
Contributor

@mboe mboe commented Jun 27, 2022

The standard zoom speed using the mouse wheel does not fit all needs. It would be nice if it can be adjusted. This tiny code change allows to override the currently fixed value.

@JaffaKetchup
Copy link
Member

Hi there @mboe, and thanks for your contribution!

Looks mostly good, but the auto checks require source files to be formatted correctly. To resolve this issue, please run dart format --fix in your fork, and push the changes. Then we should be all set to review!

@JaffaKetchup JaffaKetchup self-requested a review June 27, 2022 20:17
@mboe
Copy link
Contributor Author

mboe commented Jun 28, 2022

Hi @JaffaKetchup,

sorry, it's my first PR for a flutter-based project. I fixed the line format. Feel free to go ahead.

Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't tested, but can't go wrong. Thanks for your contribution!

Note that this is too much of a minor change to have a new version, so it will be released with the next.

@JaffaKetchup JaffaKetchup merged commit bee620c into fleaflet:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants