Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example data #1213

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Update example data #1213

merged 3 commits into from
Apr 10, 2022

Conversation

Zverik
Copy link
Contributor

@Zverik Zverik commented Apr 10, 2022

Built the example app just now, and had to update some numbers. This pull request makes it compilable without errors or warnings.

@JaffaKetchup
Copy link
Member

Looks like it should work, as I've done similar things locally. Just need to test on my system to make sure.

JaffaKetchup
JaffaKetchup approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Live location screen is still broken, but that's a separate issue (location permission not being requested at correct time due to asynchronous request). Will merge now...

@JaffaKetchup JaffaKetchup merged commit 18d6570 into fleaflet:master Apr 10, 2022
@Zverik Zverik deleted the update_example_data branch April 10, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zverik @JaffaKetchup