Encode boolean values as uppercase string in WMS request. #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle WMS server that only accepts boolean values as uppercase strings.
|
Forgive me if I'm wrong, but couldn't you just pass in the boolean string as uppercase anyway? |
|
I think currently it would have to be a bool rather than a string, and hence toString would be lowercase if I'm not mistaken (quite possible). |
| @@ -349,6 +349,9 @@ class WMSTileLayerOptions { | |||
| /// tile transparency flag | |||
| final bool transparent; | |||
There was a problem hiding this comment.
@ibrierley @stou Ah yes, I see now :)
JaffaKetchup
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
LGTM. Just waiting on maintainers to return or people to be given write access. See #1117.
|
@stou Please pull upstream when possible, then I (or another maintainer) can merge. |
|
@JaffaKetchup I have merged in the latest. Looks like the analysis and tests passes now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle WMS server that only accepts boolean values as uppercase strings.