Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Zoom change without center change does not emit move event if event source is custom #1231

Closed
5 of 11 tasks
hschendel opened this issue May 12, 2022 · 0 comments · Fixed by #1232
Closed
5 of 11 tasks

[BUG] Zoom change without center change does not emit move event if event source is custom #1231

hschendel opened this issue May 12, 2022 · 0 comments · Fixed by #1232
Labels
bug This issue reports broken functionality or another error

Comments

@hschendel
Copy link
Contributor

hschendel commented May 12, 2022 •
edited by JaffaKetchup
Loading

Describe The Bug
When the zoom is changed without a "real" move, and the event source is MapEventSource.custom, no move event is emitted by the map controller.

Expected Behavior
A zoom change changes the bounds and thus a move event is expected.

To Reproduce

To reproduce, we need to cause a zoom change with event source being custom.

On MacOS platform (most easy to reproduce just using pinch zoom, probably due to trackpad behaviour)

  1. Instantiate a FlutterMap
  2. Listen to mapEventStream
  3. Pinch zoom out or in on the Mac's trackpad without moving
  4. No event appears

Other platforms

  1. Instantiate a FlutterMap
  2. add the flutter_map_marker_cluster plugin
  3. add enough markers to cause clustering depending on zoom
  4. zoom out
  5. tap a cluster to have the marker_cluster plugin zoom in (with event source being custom)
  6. No event appears

Severity
This will help us to label the issue quicker and decide what needs attention first. Only choose fatal if the entire app crashes, otherwise choose non-fatal.

  • Non-Fatal
  • Fatal / App Crashes

Frequency/Rarity
This will help us to label the issue quicker and decide what needs attention first.

  • Once
  • Uncommon
  • Common
  • Always

Applicable Platforms
Only select those that you've tested on - one or more. If possible, test on a variety of platforms.

  • Android
  • iOS
  • Web
  • Windows
  • Others (beta platforms)
@hschendel hschendel added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels May 12, 2022
@hschendel hschendel mentioned this issue May 12, 2022
Merged
@JaffaKetchup JaffaKetchup linked a pull request May 12, 2022 that will close this issue
[BUG] Emit move event even when source is custom #1231 #1232
Merged
@JaffaKetchup JaffaKetchup added non-fatal and removed needs triage This new bug report needs reproducing and prioritizing labels May 12, 2022
JaffaKetchup pushed a commit that referenced this issue May 12, 2022
@hschendel
[BUG] Emit move event even when source is custom #1231 (#1232)
0f1d5c4 
* Emit a move event on zoom or center change when event source is custom #1231

* Remove unnecessary ? operator in example code found by dart analyze

Co-authored-by: Hagen Schendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue reports broken functionality or another error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Emit move event even when source is custom #1231
2 participants
@hschendel @JaffaKetchup