Skip to content

Conversation

@JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Nov 10, 2018

@flavorjones
Copy link
Owner

Thank you for submitting this! Renaming classes was already on my roadmap (see #155 for how I was planning to approach it along with some backwards-compatibility concerns) so I'm totally aligned on the intention.

Give me a few days to find some time to understand the changes made here and look at the failing tests. I'm a little under water at the moment.

@flavorjones
Copy link
Owner

Apologies for the long response time here -- the last few weeks have been hectic for me. This is still on my TODO list and I intend to get to it as soon as I can.

Copy link

@sorryeh sorryeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, the rest is 👍 :)

Rakefile Outdated
task :generate_whitelists do
load "tasks/generate-whitelists"
desc "generate allowlists from W3C specifications"
task :generate_allowlists do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why allowlist here instead of safelist?

Introducing a second term for the same concept does not seem right here.

Copy link

@sorryeh sorryeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@flavorjones
Copy link
Owner

Just an update: I'm struggling to find time to work on OSS; this is still something I'm very keen to do, so thanks for your patience.

@flavorjones
Copy link
Owner

Hi! I apologize for this going so long without review. I'm dedicating some time this week to my open source projects and will spend some time with this PR. Thank you again for sending such a thoughtful PR.

@JuanitoFatas
Copy link
Contributor Author

Closing in favor of #164.

@flavorjones
Copy link
Owner

v2.3.0 has been released.

@coreyward
Copy link

Offensive? “Blacklist” is not race related, either in origin or context. “Whitelist“ is it’s opposite. https://www.reddit.com/r/AskHistorians/comments/866ynp/what_are_the_origins_of_the_words_blacklist_and/

Repository owner locked as off-topic and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants