-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for v2.7.1 #89
Conversation
Started test build 84149 |
Build 84149 failed |
Started test build 84150 |
Build 84150 failed |
Started test build 84152 |
Build 84152 failed |
Started test build 84254 |
Build 84254 successful
|
Started test build 84269 |
Build 84269 successful
|
Started test build 84529 |
Build 84529 successful
|
Started test build 84553 |
Build 84553 successful
|
Started test build 84625 |
Build 84625 successful
|
Started test build 84634 |
Build 84634 successful
|
Started test build 84872 |
Build 84872 successful
|
Started test build 85164 |
Build 85164 successful
|
@AsavarTzeth Do you have merge permission on this repo? This one is ready for a review 🙏 |
@AsavarTzeth would you mind granting us ownership over this repo? |
# Access to temporary files (Remove if RuntimeDirectory patch is upstreamed) | ||
- --filesystem=/tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this comment. When do we use the tmp dir?
org.keepassxc.KeePassXC.yml
Outdated
# Required for native messaging (Tor browser) | ||
- --filesystem=xdg-data | ||
# Required for native messaging (Non-Firefox) | ||
- --filesystem=xdg-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need access to the whole xdg-data
and xdg-config
? Maybe you can limit it to well-known browsers config directories, like xdg-config/chromium
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have host
already. So everything is already accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, but at some point hopefully the host access will be removed, and we will have the granular permissions already defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented out those permissions while we have host
access configured.
@AsavarTzeth would you mind granting us ownership over this repo? I have sent you an invite. |
Accepted thank you! |
Started test build 85327 |
Build 85327 successful
|
Started test build 85345 |
Build 85345 successful
|
Merged onto |
Started test build 85359 |
Build 85359 successful
|
The goal is to have all the patches upstreamed before 2.7.1 is released.
Depends on keepassxreboot/keepassxc#7728