Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for v2.7.1 #89

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Preparing for v2.7.1 #89

merged 1 commit into from
Apr 8, 2022

Conversation

louib
Copy link
Contributor

@louib louib commented Mar 31, 2022

The goal is to have all the patches upstreamed before 2.7.1 is released.
Depends on keepassxreboot/keepassxc#7728

@flathubbot
Copy link

Started test build 84149

@flathubbot
Copy link

Build 84149 failed

@flathubbot
Copy link

Started test build 84150

@flathubbot
Copy link

Build 84150 failed

@flathubbot
Copy link

Started test build 84152

@flathubbot
Copy link

Build 84152 failed

@flathubbot
Copy link

Started test build 84254

@flathubbot
Copy link

Build 84254 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82117/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 84269

@flathubbot
Copy link

Build 84269 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82132/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 84529

@flathubbot
Copy link

Build 84529 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82390/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 84553

@flathubbot
Copy link

Build 84553 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82414/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 84625

@flathubbot
Copy link

Build 84625 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82483/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 84634

@flathubbot
Copy link

Build 84634 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82492/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 84872

@flathubbot
Copy link

Build 84872 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82724/org.keepassxc.KeePassXC.flatpakref

@flathubbot
Copy link

Started test build 85164

@louib louib marked this pull request as ready for review April 7, 2022 00:13
@flathubbot
Copy link

Build 85164 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83009/org.keepassxc.KeePassXC.flatpakref

@louib
Copy link
Contributor Author

louib commented Apr 7, 2022

@AsavarTzeth Do you have merge permission on this repo? This one is ready for a review 🙏

@droidmonkey
Copy link
Collaborator

@AsavarTzeth would you mind granting us ownership over this repo?

Comment on lines +36 to +37
# Access to temporary files (Remove if RuntimeDirectory patch is upstreamed)
- --filesystem=/tmp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this comment. When do we use the tmp dir?

Comment on lines 38 to 41
# Required for native messaging (Tor browser)
- --filesystem=xdg-data
# Required for native messaging (Non-Firefox)
- --filesystem=xdg-config
Copy link
Member

@gasinvein gasinvein Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need access to the whole xdg-data and xdg-config? Maybe you can limit it to well-known browsers config directories, like xdg-config/chromium?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have host already. So everything is already accessible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, but at some point hopefully the host access will be removed, and we will have the granular permissions already defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out those permissions while we have host access configured.

@TingPing
Copy link
Member

TingPing commented Apr 7, 2022

@AsavarTzeth would you mind granting us ownership over this repo?

I have sent you an invite.

@droidmonkey
Copy link
Collaborator

Accepted thank you!

@flathubbot
Copy link

Started test build 85327

@flathubbot
Copy link

Build 85327 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83172/org.keepassxc.KeePassXC.flatpakref

@droidmonkey droidmonkey changed the base branch from master to beta April 8, 2022 01:44
@flathubbot
Copy link

Started test build 85345

@flathubbot
Copy link

Build 85345 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83190/org.keepassxc.KeePassXC.flatpakref

@droidmonkey droidmonkey merged commit 4abb919 into flathub:beta Apr 8, 2022
@droidmonkey
Copy link
Collaborator

Merged onto beta branch for testing

@louib louib deleted the v2.7.1 branch April 8, 2022 02:31
@flathubbot
Copy link

Started test build 85359

@flathubbot
Copy link

Build 85359 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83203/org.keepassxc.KeePassXC.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants