Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime 44 #8

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Runtime 44 #8

merged 2 commits into from
Jun 5, 2023

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Jun 2, 2023

Closes #6
Closes #7

Issue for a better icon projecthamster/hamster#724 This one is upscaled from 48x48, a 128x128 icon either svg or png is mandatory but it's not supplied by upstream.

@flathubbot
Copy link

Started test build 44650

@flathubbot
Copy link

Build 44650 failed

@flathubbot
Copy link

Started test build 44655

@flathubbot
Copy link

Build 44655 failed

@flathubbot
Copy link

Started test build 44658

@flathubbot
Copy link

Build 44658 failed

@flathubbot
Copy link

Started test build 44667

@flathubbot
Copy link

Build 44667 failed

@flathubbot
Copy link

Started test build 44685

@flathubbot
Copy link

Build 44685 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27307/org.gnome.Hamster.flatpakref

@rabin-io rabin-io merged commit 4ea63b4 into flathub:master Jun 5, 2023
@rabin-io
Copy link
Collaborator

rabin-io commented Jun 5, 2023

Thank you, @bbhtt

@bbhtt bbhtt deleted the runtime-44 branch June 5, 2023 11:35
@rabin-io
Copy link
Collaborator

rabin-io commented Jun 7, 2023

@bbhtt The icon is more broken now on the site, do you know to fix it?

@bbhtt
Copy link
Contributor Author

bbhtt commented Jun 8, 2023

@bbhtt The icon is more broken now on the site, do you know to fix it?

Can you trigger a build from here https://buildbot.flathub.org/#/apps/org.gnome.Hamster? Looks like @barthalion triggered one but it failed. I'm not sure why because there were no changes after my PR and his build and mine passed.
I need to look up the E filters-but-no-output error reported there.

If it passes and is published, the icon will be updated. It might take some time for the icon to update because of CDN caching etc.

I don't see anything that I did wrong. This at least fixes the remote icon issue, previously it was the placeholder image ie. the new flathub logo. But for some reason the actual icon is gone from flathub server.

@bbhtt
Copy link
Contributor Author

bbhtt commented Jun 8, 2023

Hmm looks like they switched the program, it was using appstream-compose for the old builds but for the new ones it is using appstreamcli compose

@bbhtt
Copy link
Contributor Author

bbhtt commented Jun 8, 2023

I asked about the issue in #flatpak:matrix.org. The change is causing other builds to fail as well.

I did a bunch of tinkering with the upstream app data file: bbhtt/hamster@f5ce15f

The duplicate provides tag was making appstreamcli validate fail locally, rest of the changes are made by appstream-util upgrade.

The only thing that makes appstreamcli compose work is if I change the id tag there to match the Flatpak id.

I copied the directory build/export/share to .flatpak-builder/rofiles/rofiles-xxxxxx/files, then ran appstreamcli compose locally:

appstreamcli compose --prefix=/ --origin=org.gnome.Hamster '--components=org.gnome.Hamster,org.gnome.Hamster.desktop' .flatpak-builder/rofiles/rofiles-FsDHqw/files
Automatically selected '.flatpak-builder/rofiles/rofiles-FsDHqw/files' as data output location.
Only accepting components: org.gnome.Hamster, org.gnome.Hamster.desktop
Processing directory: .flatpak-builder/rofiles/rofiles-FsDHqw/files
Composing metadata...
Success!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon is broken on flathub website
4 participants