Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node and fix missing deps #15

Open
wants to merge 3 commits into
base: update-3b06021
Choose a base branch
from

Conversation

hovancik
Copy link
Collaborator

Try Node20

@flathubbot
Copy link
Contributor

Started test build 170496

@flathubbot
Copy link
Contributor

Build 170496 failed

Use --prefer-offline for missing deps
@hovancik hovancik changed the title Try update to node 20 Update node and fix missing deps Dec 25, 2024
@flathubbot
Copy link
Contributor

Started test build 170497

@flathubbot
Copy link
Contributor

Build 170497 failed

Don't only use offline packages
@flathubbot
Copy link
Contributor

Started test build 170498

@jwillikers
Copy link
Collaborator

@hovancik Thanks! I started poking at getting the update for Stretchly working yesterday, but was hitting some issues. I should be able to help out with this more tomorrow!

@jwillikers jwillikers self-assigned this Dec 25, 2024
@hovancik
Copy link
Collaborator Author

Thanks! There seems to be issue with one of packages that is built from github not being cached, so I am trying to make packages be installed form cache only as preferred option, but doesn't seems to work, as npm seems to be downloading it for over hour.

@flathubbot
Copy link
Contributor

Build 170498 was cancelled

@jwillikers
Copy link
Collaborator

Thanks! There seems to be issue with one of packages that is built from github not being cached, so I am trying to make packages be installed form cache only as preferred option, but doesn't seems to work, as npm seems to be downloading it for over hour.

Yes, that seems like the issue. It won't be possible to download anything during the build stage, which is why it hangs for so long during that part. Flatpaks get all source code in a separate step before the build. The build step has no internet connection. This is to make builds reproducible.

I'm wondering if it's related to the hash in the windows-quiet-hours source that's throwing things off. I've updated the dependencies in the generated-sources.json which is used to download the source of all the dependencies and see this issue. It's probably due to how the generated--sources.json file is generated, which is done using the flatpak-builder-tools/node script from this PR: flatpak/flatpak-builder-tools#382.

I'll see if I can figure out how to fix it in PR #14

@jwillikers
Copy link
Collaborator

Yeah, it's not getting patched in the package.json file like it should be:

  "dependencies": {
    "@electron/remote": "^2.1.2",
    "auto-launch": "^6.0.0-rc1",
    "dbus-final": "git+file:///var/home/jordan/Projects/net.hovancik.Stretchly/.flatpak-builder/build/stretchly-18/flatpak-node/git-packages/dbus-final-3e43f60d80bbcdf0dfa0b59b838097d6af4d17ba#3e43f60d80bbcdf0dfa0b59b838097d6af4d17ba",
    "electron-log": "^5.2.4",
    "electron-store": "^8.2.0",
    "humanize-duration": "^3.32.1",
    "i18next": "^23.16.8",
    "i18next-fs-backend": "^2.6.0",
    "luxon": "^3.5.0",
    "macos-notification-state": "^3.0.0",
    "meeussunmoon": "^3.0.3",
    "ps-list": "7.2",
    "rtl-detect": "^1.1.2",
    "semver": "^7.6.3",
    "windows-focus-assist": "^1.4.0",
    "windows-quiet-hours": "github:hovancik/windows-quiet-hours#fix-LPTSTR"
  }

@hovancik
Copy link
Collaborator Author

Strange, as "dbus-final": "github:Jelmerro/dbus-final", also comes from github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants