-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: add in.srev.guiscrcpy #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68012 |
Build 68012 failed |
52e624b
to
0d09052
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68013 |
Build 68013 failed |
0d09052
to
b34f63a
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68015 |
Build 68015 failed |
b34f63a
to
9d0139d
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68018 |
Build 68018 failed |
9d0139d
to
e818a5f
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68022 |
Build 68022 failed |
e818a5f
to
c4a9aa3
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68025 |
Build 68025 failed |
c4a9aa3
to
aad957c
Compare
Build 68065 failed |
aad957c
to
a571cfe
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68066 |
Build 68066 successful
|
@barthalion can you please review this PR when you get time? :D |
in.srev.guiscrcpy.yml
Outdated
- "--socket=x11" | ||
- "--socket=wayland" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this support wayland:
- "--socket=x11" | |
- "--socket=wayland" | |
- "--socket=fallback-x11" | |
- "--socket=wayland" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I tried running with that, but it looks like one of the dependency doesn't know how to get screenheight if "--socket=fallback-x11" is passed. So I will leave it as is I think,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means it will have that issue in a wayland only setup. You can test this by passing --nosocket=x11 when you run it locally So in that case you should remove --socket=wayland entirely and it'll run using xwayland for those users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having both x11 and wayland allow both. I do that for DispCAL. Sounds like a justification enough for it (I'd add a comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I tried running the flatpak with --nosocket=x11
and it seems to just work (but certain things like window size doesnt work properly), so, should I remove --socket=wayland
as well?
a571cfe
to
13fcdfd
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68153 |
Build 68153 failed |
13fcdfd
to
8dba3a6
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68170 |
Build 68170 successful
|
8dba3a6
to
2845f5e
Compare
bot, build in.srev.guiscrcpy |
Queued test build for in.srev.guiscrcpy. |
Started test build 68174 |
Build 68174 successful
|
/merge |
A repository for this has been created: https://github.com/flathub/in.srev.guiscrcpy You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Thank you everyone for your feedback! ✨ |
guiscrcpy is an open source android screen mirroring client with a GUI abstraction for scrcpy
Please confirm your submission meets all the criteria