Skip to content

feat: add in.srev.guiscrcpy #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

srevinsaju
Copy link

guiscrcpy is an open source android screen mirroring client with a GUI abstraction for scrcpy

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68012

@flathubbot
Copy link

Build 68012 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68013

@flathubbot
Copy link

Build 68013 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68015

@flathubbot
Copy link

Build 68015 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68018

@flathubbot
Copy link

Build 68018 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68022

@flathubbot
Copy link

Build 68022 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68025

@flathubbot
Copy link

Build 68025 failed

@flathubbot
Copy link

Build 68065 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68066

@flathubbot
Copy link

Build 68066 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65900/in.srev.guiscrcpy.flatpakref

@srevinsaju
Copy link
Author

srevinsaju commented Nov 23, 2021

@barthalion can you please review this PR when you get time? :D

Comment on lines 124 to 125
- "--socket=x11"
- "--socket=wayland"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this support wayland:

Suggested change
- "--socket=x11"
- "--socket=wayland"
- "--socket=fallback-x11"
- "--socket=wayland"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tried running with that, but it looks like one of the dependency doesn't know how to get screenheight if "--socket=fallback-x11" is passed. So I will leave it as is I think,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means it will have that issue in a wayland only setup. You can test this by passing --nosocket=x11 when you run it locally So in that case you should remove --socket=wayland entirely and it'll run using xwayland for those users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having both x11 and wayland allow both. I do that for DispCAL. Sounds like a justification enough for it (I'd add a comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tried running the flatpak with --nosocket=x11 and it seems to just work (but certain things like window size doesnt work properly), so, should I remove --socket=wayland as well?

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68153

@flathubbot
Copy link

Build 68153 failed

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68170

@flathubbot
Copy link

Build 68170 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66003/in.srev.guiscrcpy.flatpakref

@srevinsaju
Copy link
Author

bot, build in.srev.guiscrcpy

@flathubbot
Copy link

Queued test build for in.srev.guiscrcpy.

@flathubbot
Copy link

Started test build 68174

@flathubbot
Copy link

Build 68174 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66007/in.srev.guiscrcpy.flatpakref

@nedrichards
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this has been created: https://github.com/flathub/in.srev.guiscrcpy

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Nov 26, 2021
@srevinsaju
Copy link
Author

Thank you everyone for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants