Provide a mock gnome-screenshot command to take screenshots using the xdg-desktop-portal DBus API #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… xdg-desktop-portal DBus API The app does not use the xdg-desktop-portal API for screenshots yet. It can fall back to using the gnome-screenshot command. That is not provided by the runtime. Instead this commit adds a mock gnome-screenshot command that uses the portal API for taking screenshots and saves them to a file. This makes loading QR codes work from within a flatpak. flathub#78 Yubico/yubioath-flutter#1010
|
Started test build 173713 |
|
Build 173713 successful |
|
I tested the above test build and the screenshot capability works. |
|
is it supposed to work everywhere or only on gnome? |
|
This should work on any system where the portal offers the screenshot capability. The added Python file here just uses DBus to speak to This is the snippet in the Yubioath app that calls into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app does not use the xdg-desktop-portal API for screenshots yet. It can fall back to using the gnome-screenshot command. That is not provided by the runtime.
Instead this commit adds a mock gnome-screenshot command that uses the portal API for taking screenshots and saves them to a file. This makes loading QR codes work from within a flatpak.
#78
Yubico/yubioath-flutter#1010