Make error router fall back to flask error handler #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flask-restful library was original designed to handle all errors that happen within the domain of its restful endpoints. This design decision collides with the assumption other library writers make, trusting the custom error handlers they set up in the base app to kick in when they throw one of their custom exception. Given that flask-restful hijacks `app.handle_exception` on initialization, that assumption of the latter developers causes some libraries to fail. By making the flask-restful error_router fall back onto the `original_handler` when the local one can't handle / re-raises the exception, we return the control to the third-party extension handler for a last attempt at handling. This is probably the case too for the `app.handle_user_exception` hijacking, but it wasn't investigated this time around.
joshfriend
added a commit
that referenced
this pull request
Dec 4, 2014
Make error router fall back to flask error handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296 and adds tests.