Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Use
detin the canonical backend names of the delivered deterministic training families, and a finalkcpsuffix for context-parallel routes. For example,cake_gdn_trainbecomescake_gdn_det_train_kcp, and KDA and causal conv1d get explicit local and KCP entry modules.This covers GDN, KDA, LM head/loss, grouped MoE GEMM, dense projection, mHC, RMSNorm, RMSNorm + SiLU gate, and causal conv1d. Legacy imports forward to the canonical implementation, sharing function/class identity and module state. Update consumer imports, package data, build manifests, generated-source formatting exclusions, and documentation together. The manifest checker also includes the shipped KDA and conv1d KCP sibling registries.
GQA and DSA keep their names because their backward paths use floating atomic reductions. MoK keeps its name because full distributed determinism has not been established.
detmeans repeatability with fixed inputs, hardware, execution plan and initial accumulation buffers; it does not promise identical bits across architectures or partitions. This change encodes the existing contract and does not alter numerical algorithms.Generated CUDA source and binary program identifiers retain their contents and identity.
docs/training_backend_names.mdlists every canonical name and exception.🔍 Related Issues
🚀 Pull Request Checklist
✅ Pre-commit Checks
pre-commit.pre-commit install.pre-commit run --all-files.🧪 Tests
CPU validation:
check_cake_build_manifests.py: zero findings.GPU compilation, graph execution, numerical parity and determinism tests have not been rerun for this naming change. Keep draft pending integration validation.
Suggested CI targets:
tests/experimental/test_cake_training_names.py tests/experimental/test_cake_gdn_train_api.py tests/experimental/test_cake_kda_train_api.py tests/experimental/test_cake_lm_head_loss_api.py tests/experimental/test_cake_moe_grouped_gemm_api.py tests/norm/test_cake_rmsnorm_train_api.py tests/norm/test_cake_causal_conv1d_train_api.py tests/mhc/test_cake_mhc_train_api.py🔬 Experimental Track
Reviewer Notes
Review both legacy import compatibility and the explicit KCP routes. Source-directory moves account for most files; unchanged generated sources should be reviewed as renames. No performance improvement is claimed.