Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThis change adds SM100 CuTeDSL MegaMoE support for BF16 activations with MXFP8 weights. It includes weight transformation, mixed kernel execution, references, autotuning, runtime wiring, runners, and Blackwell integration tests. ChangesMixed backend contracts and weight preparation
Mixed CuTeDSL API and execution
References, runners, and validation
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Backend
participant MegaMoEBf16Mxfp8Frontend
participant Sm100MegaMoEMxfp8Bf16Kernel
participant MixedGluBf16Epilogue
participant BF16Reference
Backend->>MegaMoEBf16Mxfp8Frontend: validate inputs and prepare transformed weights
MegaMoEBf16Mxfp8Frontend->>Sm100MegaMoEMxfp8Bf16Kernel: compile and launch mixed FC1/FC2 kernel
Sm100MegaMoEMxfp8Bf16Kernel->>MixedGluBf16Epilogue: process accumulator tiles and write BF16 output
Backend->>BF16Reference: decode MXFP8 weights and compute reference
MixedGluBf16Epilogue-->>Backend: return kernel output for comparison
BF16Reference-->>Backend: return BF16 reference output
Merge Risk: 🟠 High · up to This PR adds SM100 MXFP8 × BF16 support, but the current implementation still has unresolved correctness and lifecycle issues that can accept invalid results, hide workspace regressions, leave stale resources referenced, or fail to restore runtime state after errors; merge should be blocked until these issues are fixed or explicitly accepted. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the SM100 MXFP8 × BF16 MegaMoE integration, links related issue ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
ready to review? (still draft) looks good so far |
PR Review ScreeningRe-screened 2026-09-03 — supersedes the earlier result on this PR, which was taken while it was a draft with an empty description. The PR is now marked ready, the template is filled, and the category moves CI verdict: ✅ auto-run ok Security
Packaging
Presentation
Implementation
Experimental track
Notes for the maintainer
Generated by flashinfer-pr-screen · rubric: docs/code_review_guidance.md · not a code review · AI screening can make mistakes — a maintainer's judgment supersedes this report. |
243d79e to
6177dc2
Compare
Its functional, I have PR in sglang that passes with it. Most of it is agent slop still, so I want to review it properly myself before asking the team to spend time on it. |
…to work with ikr off
8566a9d to
4d7ac8a
Compare
|
/bot run tests/moe_ep |
|
[SUCCESS] Pipeline #67703049: 18/19 executed test jobs passed |
📌 Description
Adds support for SM100 MXFP8 x BF16 MegaMOE to flashinfer
🔍 Related Issues
#3781
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Downstream PR demonstrating framework integration: https://github.com/sgl-project/sglang/pull/35459/commits
Summary by CodeRabbit
New Features
Documentation
Tests