test incidental support for fp32 unpacked expert weights from #3763

[jdebache]

📌 Description

Add unpacked FP32 routing coverage for BF16, FP8, FP4, and MXFP8 routed MoE paths.

🔍 Related Issues

Testing to address this comment: vllm-project/vllm#46872 (review).

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

• I have installed pre-commit by running pip install pre-commit (or used your preferred method).
• I have installed the hooks with pre-commit install.
• I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

🧪 Tests

• Tests have been added or updated as needed.
• All tests are passing (unittest, etc.).

Reviewer Notes

None.

Summary by CodeRabbit

• Tests
  • Expanded routed mixture-of-experts coverage to support both packed and unpacked FP32 routing inputs.
  • Added coverage for BF16, FP8 block-scale, and FP4 block-scale implementations.
  • Improved activation-parity checks to report the routing format when mismatches occur.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f207e68a-23b0-4921-8076-5c66dda468c6

📥 Commits

Reviewing files that changed from the base of the PR and between 2fb785c and 6c54ed0.

📒 Files selected for processing (1)

• tests/moe/test_trtllm_gen_routed_fused_moe.py

---

📝 Walkthrough

Walkthrough

Routed MoE tests now support packed and unpacked FP32 routing inputs. Coverage includes BF16, FP8 block-scale, FP4 block-scale, and MXFP8 activation-parity paths.

Changes

Routed MoE routing formats

Layer / File(s)	Summary
Routing input selection tests/moe/test_trtllm_gen_routed_fused_moe.py	FP8 and BF16 helpers accept packed or unpacked FP32 routing and pass the matching kernel input.
Routed format test coverage tests/moe/test_trtllm_gen_routed_fused_moe.py	Parameterized tests cover unpacked FP32 routing for BF16, FP8 block-scale, and FP4 block-scale paths. Existing packed wrapper coverage remains parameterized.
MXFP8 parity formats tests/moe/test_trtllm_gen_routed_fused_moe.py	The activation-parity test covers both routing formats and includes the selected format in mismatch failures.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• flashinfer-ai/flashinfer#4180: Modifies the same routed MoE tests and shared helper parameter handling.
• flashinfer-ai/flashinfer#4265: Modifies the same MXFP8 activation-parity test and related activation coverage.
• flashinfer-ai/flashinfer#4352: Adds related tests for unpacked FP32 routing across routed MoE paths.

Suggested labels: run-ci

Suggested reviewers: aleozlx, yzh119, iwakurarein

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies testing support for unpacked FP32 expert weights, which matches the main change despite using the vague term "incidental."
Description check	✅ Passed	The description includes the required sections, explains the coverage, links related context, and reports completed checks and tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bkryu]

/bot run tests/moe

[flashinfer-bot]

GitLab MR !1177 has been created, and the CI pipeline #62006206 is currently running. I'll report back once the pipeline job completes.