fix(test): mock the DEEPGEMM_RUBIN pin in test_get_subdir_file_list

[aleozlx]

📌 Description

tests/test_artifacts.py::test_get_subdir_file_list has been failing on main since #4280:

FileNotFoundError: [Errno 2] No such file or directory:
  '/tmp/pytest-of-root/pytest-0/test_get_subdir_file_list0/cubins/7ec7ac40b9fd48172651b77ff2ebe20d79decc39/deep-gemm/checksums.txt'

Root cause. #4280 added ArtifactPath.DEEPGEMM_RUBIN and appended it to the cubin_dirs
list walked by get_subdir_file_list(). The same PR registered responses mocks for the two
other new Rubin pins (TRTLLM_GEN_BMM_RUBIN, TRTLLM_GEN_GEMM_RUBIN) but not for the
deep-gemm one. Under @responses.activate an unregistered URL raises ConnectionError, so
download_file() exhausts its 4 retries and returns False; get_checksums() ignores that
return value and open()s a checksums.txt that was never written.

The artifact itself is fine — I fetched both deep-gemm manifests from artifactory (HTTP 200)
and the live SHA256 of 7ec7ac40…/deep-gemm/checksums.txt matches the pin in
CheckSumHash.DEEPGEMM_RUBIN (09e961d4…). Only the unit test's mock registry was stale, so no
production download path is affected.

Changes:

• tests/test_artifacts.py: register the DEEPGEMM_RUBIN directory index and checksums.txt,
  mirroring the BMM/GEMM Rubin pattern (same index body, distinct per-pin hashes).
• tests/test_artifacts.py: extend the existing per-pin-hash-collision assertion to a shared
  deep-gemm kernel name, so deep-gemm gets the same regression coverage the trtllm-gen pins have.
• flashinfer/artifacts.py: get_checksums() now raises a RuntimeError naming the pin and the
  URL when the manifest download fails, instead of falling through to a bare FileNotFoundError
  on a local cache path. That failure mode is what made this read as a cache bug rather than
  "a pin was added without a mock".

🔍 Related Issues

Regression from #4280. Observed on unrelated PR CI, e.g.
https://github.com/flashinfer-ai/flashinfer/actions/runs/30607427968/job/91082694368

🚀 Pull Request Checklist

✅ Pre-commit Checks

• I have installed pre-commit by running pip install pre-commit (or used your preferred method).
• I have installed the hooks with pre-commit install.
• I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

🧪 Tests

• Tests have been added or updated as needed.
• All tests are passing (unittest, etc.) — verification in progress on a dev box; draft until tests/test_artifacts.py is confirmed green.

Reviewer Notes

CPU-only change; no kernel or GPU behavior is touched. The get_checksums() error-path change is
the only non-test edit — it converts a silent-download-failure into a diagnosable error and does
not alter the success path.

AI-assisted (Claude Code): diagnosis and patch.

Summary by CodeRabbit

• Bug Fixes
  • Improved checksum validation when artifact manifests are unavailable.
  • Errors now clearly identify the affected artifact and repository instead of producing a less informative file-not-found error.
  • Added fallback to cached checksum manifests when refreshing from a repository fails.
  • Prevented checksum collisions for shared kernel filenames across different DeepGEMM paths, including the Rubin variant.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[coderabbitai]

📝 Walkthrough

Walkthrough

get_checksums now reports unavailable checksum manifests with a descriptive error. Tests cover cached manifests and distinct checksums for shared filenames across regular and Rubin DeepGEMM paths.

Changes

Checksum validation

Layer / File(s)	Summary
Manifest availability validation flashinfer/artifacts.py, tests/test_artifacts.py	get_checksums raises a RuntimeError when a checksum manifest is unavailable locally and cannot be downloaded. Tests verify the error and cached-manifest fallback.
DeepGEMM checksum regression coverage tests/test_artifacts.py	Tests mock DeepGEMM Rubin endpoints, add distinct Rubin checksum fixtures, and compare regular and Rubin checksums for shared filenames.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: aneureka, vinnie6167

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary fix: adding the missing DEEPGEMM_RUBIN mock for test_get_subdir_file_list.
Description check	✅ Passed	The description covers the root cause, changes, related issue, checklist, test status, and reviewer notes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[coderabbitai]

🧹 Nitpick comments (2)

flashinfer/artifacts.py (1)

229-237: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add a regression test for the missing-manifest error.

get_checksums now has a new failure branch at Lines [229]-[237]. The supplied tests cover successful manifests, but they do not exercise a failed download with no cached file. Add a test that asserts RuntimeError contains the artifact pin and manifest URL. This protects the new diagnostic contract.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@flashinfer/artifacts.py` around lines 229 - 237, Add a regression test for
the get_checksums failure path where download_file returns false and no checksum
manifest exists in the cache. Mock the download and filesystem dependencies as
needed, assert that RuntimeError is raised, and verify its message contains both
the artifact pin (subdir) and manifest URL.

tests/test_artifacts.py (1)

507-511: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Assert the expected checksum for each DeepGEMM path.

The added case only feeds the existing inequality assertion. That detects a bare-filename collision, but it does not prove that the regular path receives the regular manifest hash and the Rubin path receives the Rubin manifest hash. Add expected hashes to this case and assert both exact values. A swapped mapping could otherwise pass.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_artifacts.py` around lines 507 - 511, Update the DeepGEMM case in
the artifact-path test to include the expected regular and Rubin manifest
checksums, then assert each resolved path against its corresponding exact hash.
Keep the existing inequality assertion, and ensure the assertions distinguish
the regular mapping from the Rubin mapping so swapped values cannot pass.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@flashinfer/artifacts.py`:
- Around line 229-237: Add a regression test for the get_checksums failure path
where download_file returns false and no checksum manifest exists in the cache.
Mock the download and filesystem dependencies as needed, assert that
RuntimeError is raised, and verify its message contains both the artifact pin
(subdir) and manifest URL.

In `@tests/test_artifacts.py`:
- Around line 507-511: Update the DeepGEMM case in the artifact-path test to
include the expected regular and Rubin manifest checksums, then assert each
resolved path against its corresponding exact hash. Keep the existing inequality
assertion, and ensure the assertions distinguish the regular mapping from the
Rubin mapping so swapped values cannot pass.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ae502f02-aea5-4b84-92c9-0a9c1f866339

📥 Commits

Reviewing files that changed from the base of the PR and between dca5546 and 6f5e6ca.

📒 Files selected for processing (2)

• flashinfer/artifacts.py
• tests/test_artifacts.py

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/test_artifacts.py`:
- Around line 317-320: Update the RuntimeError assertion in the checksum test
around artifacts.get_checksums to also construct the expected manifest URI using
the same safe_urljoin expression used by the artifact implementation, then
assert that URI appears in str(excinfo.value) alongside DEEPGEMM_RUBIN.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 50c63583-a651-4f4d-997c-4f7dcb439fbe

📥 Commits

Reviewing files that changed from the base of the PR and between 6f5e6ca and 7b1981e.

📒 Files selected for processing (1)

• tests/test_artifacts.py

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Assert the manifest URL as well as the pin.

The RuntimeError contract includes both values. This test checks only DEEPGEMM_RUBIN. An error that omits the URL still passes. Build the expected URI with the same safe_urljoin expression as flashinfer/artifacts.py:222-249 and assert that it is present.

Proposed test assertion

     assert artifact_paths.DEEPGEMM_RUBIN in str(excinfo.value)
+    expected_uri = safe_urljoin(
+        artifacts.FLASHINFER_CUBINS_REPOSITORY,
+        safe_urljoin(artifact_paths.DEEPGEMM_RUBIN, "checksums.txt"),
+    )
+    assert expected_uri in str(excinfo.value)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	with pytest.raises(RuntimeError) as excinfo:
	artifacts.get_checksums([artifact_paths.DEEPGEMM_RUBIN])
	# The pin must be named -- that is the whole point of the error.
	assert artifact_paths.DEEPGEMM_RUBIN in str(excinfo.value)
	with pytest.raises(RuntimeError) as excinfo:
	artifacts.get_checksums([artifact_paths.DEEPGEMM_RUBIN])
	# The pin must be named -- that is the whole point of the error.
	assert artifact_paths.DEEPGEMM_RUBIN in str(excinfo.value)
	expected_uri = safe_urljoin(
	artifacts.FLASHINFER_CUBINS_REPOSITORY,
	safe_urljoin(artifact_paths.DEEPGEMM_RUBIN, "checksums.txt"),
	)
	assert expected_uri in str(excinfo.value)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_artifacts.py` around lines 317 - 320, Update the RuntimeError
assertion in the checksum test around artifacts.get_checksums to also construct
the expected manifest URI using the same safe_urljoin expression used by the
artifact implementation, then assert that URI appears in str(excinfo.value)
alongside DEEPGEMM_RUBIN.

[aleozlx]

/bot run tests/gemm

[flashinfer-bot]

GitLab MR !1090 has been created, and the CI pipeline #60450915 is currently running. I'll report back once the pipeline job completes.

[Aneureka]

LGTM.

[flashinfer-bot]

[SUCCESS] Pipeline #60450915: 18/18 executed test jobs passed

[aleozlx]

closing in favor of #4301