Skip to content

Update moe cubins to fix 2CTA hanging issue - #3972

Closed
IwakuraRein wants to merge 1 commit into
flashinfer-ai:mainfrom
IwakuraRein:upd-artifactory-cubins
Closed

IwakuraRein wants to merge 1 commit into
flashinfer-ai:mainfrom
IwakuraRein:upd-artifactory-cubins

Conversation

@IwakuraRein

@IwakuraRein IwakuraRein commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

📌 Description

  • Update the MoE cubins. Fix the hanging issue of 2CTA kernels after v0.6.8

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Summary by CodeRabbit

  • Bug Fixes

    • Updated the default artifact download location to the current repository endpoint.
    • Corrected the path and checksum for the TRTLLM generation artifact to ensure successful retrieval and validation.
  • Documentation

    • Updated the environment-variable reference to reflect the new artifact repository URL.

Signed-off-by: Siyuan Fu <siyuanf@nvidia.com>
@IwakuraRein

Copy link
Copy Markdown
Collaborator Author

/bot run

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default repository URL for downloading FlashInfer cubins to a new Artifactory path in both the documentation (CLAUDE.md) and the loader implementation (flashinfer/jit/cubin_loader.py). Additionally, it updates the artifact path and checksum hash for TRTLLM_GEN_BMM in flashinfer/artifacts.py. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated the default cubin repository URL in runtime configuration and documentation. Changed the TRTLLM_GEN_BMM artifact subdirectory and its checksum manifest hash in the artifact registry.

Changes

Artifact configuration

Layer / File(s) Summary
Artifact metadata and repository defaults
flashinfer/artifacts.py, flashinfer/jit/cubin_loader.py, CLAUDE.md
The TRTLLM_GEN_BMM artifact path and checksum were updated, and the documented and runtime default repository URLs now use the new Artifactory endpoint.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: saltyminty

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: updating MoE cubins to address the 2CTA hanging issue.
Description check ✅ Passed The description follows the template and includes the change summary, related issue, checklist, tests, and reviewer notes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@flashinfer-bot

Copy link
Copy Markdown
Collaborator

GitLab MR !961 has been created, and the CI pipeline #58002830 is currently running. I'll report back once the pipeline job completes.

@IwakuraRein
IwakuraRein marked this pull request as draft July 14, 2026 18:15
@flashinfer-bot

Copy link
Copy Markdown
Collaborator

[CANCELING] Pipeline #58002830: canceled

@IwakuraRein IwakuraRein changed the title update cubin artifactory url; update moe cubins to fix 2CTA hanging issue Update moe cubins to fix 2CTA hanging issue Jul 14, 2026
@IwakuraRein
IwakuraRein deleted the upd-artifactory-cubins branch July 14, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants