test: correct XQA NVFP4 skip reason to SM120/SM121 - #3510
Conversation
…item 17) The skipif predicate on test_xqa_batch_decode_nvfp4_kv already covers all SM12x GPUs (compute_capability[0] in [12]), but the reason string only mentioned SM120. Update the wording so it accurately reflects what the predicate gates. Verified on SM121 (DGX Spark, GB10): the test now actually executes (rather than skipping on non-SM12x hardware) and all 6 parametrize variants pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesTest SM Support Gating
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the skip reason message in the test_xqa_batch_decode test to indicate that XQA with NVFP4 KV is supported on both SM120 and SM121 GPUs. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The skipif predicate on test_xqa_batch_decode_nvfp4_kv covers all SM12x GPUs, but the reason string only mentioned SM120. This updates the wording to match.
Verified on SM121 (DGX Spark, GB10): the test now executes (instead of skipping on non-SM12x hardware) and all 6 parametrize variants pass.
Follows #3170
Summary by CodeRabbit