Skip to content

test: correct XQA NVFP4 skip reason to SM120/SM121 - #3510

Merged
qsang-nv merged 1 commit into
flashinfer-ai:mainfrom
deng451e:fix/3170-xqa-nvfp4-reason-string
Jun 8, 2026
Merged

qsang-nv merged 1 commit into
flashinfer-ai:mainfrom
deng451e:fix/3170-xqa-nvfp4-reason-string

Conversation

@deng451e

@deng451e deng451e commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The skipif predicate on test_xqa_batch_decode_nvfp4_kv covers all SM12x GPUs, but the reason string only mentioned SM120. This updates the wording to match.
Verified on SM121 (DGX Spark, GB10): the test now executes (instead of skipping on non-SM12x hardware) and all 6 parametrize variants pass.
Follows #3170

Summary by CodeRabbit

  • Tests
    • Updated GPU support configuration for batch decode tests to include SM121 GPU architecture alongside SM120.

…item 17)

The skipif predicate on test_xqa_batch_decode_nvfp4_kv already covers all
SM12x GPUs (compute_capability[0] in [12]), but the reason string only
mentioned SM120. Update the wording so it accurately reflects what the
predicate gates.

Verified on SM121 (DGX Spark, GB10): the test now actually executes
(rather than skipping on non-SM12x hardware) and all 6 parametrize
variants pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3b56ff80-591f-4bcc-91bd-7efc4e422683

📥 Commits

Reviewing files that changed from the base of the PR and between 993a9b2 and c66f369.

📒 Files selected for processing (1)
  • tests/attention/test_xqa_batch_decode.py

📝 Walkthrough

Walkthrough

This PR updates the pytest.mark.skipif skip reason for the test_xqa_batch_decode_nvfp4_kv test to clarify that NVFP4 KV support extends to both SM120 and SM121 GPU architectures, instead of SM120 only.

Changes

Test SM Support Gating

Layer / File(s) Summary
SM support gating clarification
tests/attention/test_xqa_batch_decode.py
The skip reason for the NVFP4 KV batch decode test is updated to document that the variant is supported on SM120/SM121 GPUs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

run-ci, op: attention, arch: DGX Spark

Suggested reviewers

  • yzh119
  • saltyminty
  • kahyunnam

Poem

A GPU's reach expands with grace,
SM121 joins the race,
One line revised, a truth made clear,
NVFP4's kingdom draws more near. 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the issue, the fix applied, and verification performed, but does not follow the required template structure with sections like Description, Related Issues, and Checklist. Reorganize the description to follow the repository template: add a Description section, link the related issue (#3170), and complete the Pull Request Checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: correcting the skip reason documentation for the XQA NVFP4 test to accurately reflect SM120/SM121 support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the skip reason message in the test_xqa_batch_decode test to indicate that XQA with NVFP4 KV is supported on both SM120 and SM121 GPUs. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@qsang-nv qsang-nv added the run-ci label Jun 5, 2026
@qsang-nv
qsang-nv merged commit 0ba7a3f into flashinfer-ai:main Jun 8, 2026
42 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants